Re: [PATCH v3 2/7] usermodehelper: Export _exec() and _setup() functions

From: Lucas De Marchi
Date: Tue Mar 12 2013 - 17:53:19 EST


On Tue, Mar 12, 2013 at 5:31 PM, Andrew Morton
<akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, 11 Mar 2013 21:48:06 -0300 Lucas De Marchi <lucas.demarchi@xxxxxxxxxxxxxx> wrote:
>
>> call_usermodehelper_setup() + call_usermodehelper_exec() need to be
>> called instead of call_usermodehelper_fns() when the cleanup function
>> needs to be called even when an ENOMEM error occurs. In this case using
>> call_usermodehelper_fns() the user can't distinguish if the cleanup
>> function was called or not.
>
> call_usermodehelper_exec() was exported to modules but
> call_usermodehelper_setup() was not?
>

That was a mistake. We need both functions exported. Should I send and
updated patch or a fixup?


Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/