Re: [PATCH v2] ARM: tegra: expose chip ID and revision

[Russell King - ARM Linux]

On Tue, Mar 12, 2013 at 08:01:07PM +0800, Danny Huang wrote:
> +	if (IS_ERR_OR_NULL(soc_dev))

Sigh.  NAK.  Fur cryin out loud!  Use the IS_ERR() version.

And you don't need the following "return;" statement - that's already
implied at the closing brace of a function.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/