Re: [PATCH 2/4] writeback: remove unused bdi_pending_list

From: Jan Kara
Date: Tue Mar 12 2013 - 08:02:10 EST


On Thu 07-03-13 13:44:07, Tejun Heo wrote:
> There's no user left. Remove it.
>
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Cc: Jens Axboe <axboe@xxxxxxxxx>
> Cc: Fengguang Wu <fengguang.wu@xxxxxxxxx>
Looks good. You can add
Reviewed-by: Jan Kara <jack@xxxxxxx>

Honza

> ---
> include/linux/backing-dev.h | 1 -
> mm/backing-dev.c | 4 +---
> 2 files changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
> index 3504599..a5ef27f 100644
> --- a/include/linux/backing-dev.h
> +++ b/include/linux/backing-dev.h
> @@ -130,7 +130,6 @@ void bdi_lock_two(struct bdi_writeback *wb1, struct bdi_writeback *wb2);
>
> extern spinlock_t bdi_lock;
> extern struct list_head bdi_list;
> -extern struct list_head bdi_pending_list;
>
> static inline int wb_has_dirty_io(struct bdi_writeback *wb)
> {
> diff --git a/mm/backing-dev.c b/mm/backing-dev.c
> index 41733c5..657569b 100644
> --- a/mm/backing-dev.c
> +++ b/mm/backing-dev.c
> @@ -31,13 +31,11 @@ EXPORT_SYMBOL_GPL(noop_backing_dev_info);
> static struct class *bdi_class;
>
> /*
> - * bdi_lock protects updates to bdi_list and bdi_pending_list, as well as
> - * reader side protection for bdi_pending_list. bdi_list has RCU reader side
> + * bdi_lock protects updates to bdi_list. bdi_list has RCU reader side
> * locking.
> */
> DEFINE_SPINLOCK(bdi_lock);
> LIST_HEAD(bdi_list);
> -LIST_HEAD(bdi_pending_list);
>
> void bdi_lock_two(struct bdi_writeback *wb1, struct bdi_writeback *wb2)
> {
> --
> 1.8.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/