Re: [PATCH 1/3] workqueue: define mod_scheduled_delayed_work[_on]() helpers

From: Rafael J. Wysocki
Date: Mon Mar 11 2013 - 19:21:23 EST


On Wednesday, February 27, 2013 04:59:10 PM Viresh Kumar wrote:
> The only difference between schedule_delayed_work[_on]() and
> queue_delayed_work[_on]() is the workqueue, work is scheduled on. We may need to
> modify the delay for works queued with schedule_delayed_work[_on]() calls and
> thus adding these helpers.
>
> First users of these new helpers is cpufreq governors which need to modify the
> delay for its works.
>
> Cc: Tejun Heo <tj@xxxxxxxxxx>
> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

Do I assume correctly that you have withdrawn this patch?

Rafael


> ---
> include/linux/workqueue.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
> index 2b58905..864c2b3 100644
> --- a/include/linux/workqueue.h
> +++ b/include/linux/workqueue.h
> @@ -412,6 +412,7 @@ extern bool schedule_delayed_work_on(int cpu, struct delayed_work *work,
> extern bool schedule_delayed_work(struct delayed_work *work,
> unsigned long delay);
> extern int schedule_on_each_cpu(work_func_t func);
> +
> extern int keventd_up(void);
>
> int execute_in_process_context(work_func_t fn, struct execute_work *);
> @@ -465,6 +466,11 @@ static inline long work_on_cpu(unsigned int cpu, long (*fn)(void *), void *arg)
> long work_on_cpu(unsigned int cpu, long (*fn)(void *), void *arg);
> #endif /* CONFIG_SMP */
>
> +#define mod_scheduled_delayed_work_on(cpu, dwork, delay) \
> + mod_delayed_work_on(cpu, system_wq, dwork, delay)
> +#define mod_scheduled_delayed_work(dwork, delay) \
> + mod_delayed_work(system_wq, dwork, delay)
> +
> #ifdef CONFIG_FREEZER
> extern void freeze_workqueues_begin(void);
> extern bool freeze_workqueues_busy(void);
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/