Re: [PATCH] ARM:kernel: beautify code, using 'static const' insteadof 'const static'

From: Chen Gang
Date: Mon Mar 11 2013 - 01:03:26 EST


ä 2013å03æ11æ 09:26, Rob Herring åé:
> On 03/09/2013 07:59 PM, Chen Gang wrote:
>> >
>> > better using 'static const' instead of 'const static'
>> >
>> > Signed-off-by: Chen Gang <gang.chen@xxxxxxxxxxx>
>> > ---
>> > arch/arm/kernel/smp_twd.c | 2 +-
>> > 1 files changed, 1 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/arch/arm/kernel/smp_twd.c b/arch/arm/kernel/smp_twd.c
>> > index 3f25650..ef3e499 100644
>> > --- a/arch/arm/kernel/smp_twd.c
>> > +++ b/arch/arm/kernel/smp_twd.c
>> > @@ -362,7 +362,7 @@ int __init twd_local_timer_register(struct twd_local_timer *tlt)
>> > }
>> >
>> > #ifdef CONFIG_OF
>> > -const static struct of_device_id twd_of_match[] __initconst = {
>> > +static const struct of_device_id twd_of_match[] __initconst = {
> This will go away with conversion to use CLKSRC_OF.

excuse me, I am not quite familiar with ARM, so I do not quite
understand what you said.

could you describe it with more details ?
and how about this patch ?
a. do not need this patch.
b. or this patch need improving.
c. or this patch is ok, can be applied.

thanks.

--
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/