Re: [PATCH] eicon: Fixed checkpatch warning

[David Miller]

From: David Miller <davem@xxxxxxxxxxxxx>
Date: Sun, 10 Mar 2013 16:56:13 -0400 (EDT)

> From: Andreea Hodea <andreea.cristina.hodea@xxxxxxxxx>
> Date: Sun, 10 Mar 2013 14:34:36 +0200
> 
>> drivers/isdn/hardware/eicon/diva_didd.c:32:6: warning: symbol
>> 'DRIVERRELEASE_DIDD' was not declared. Should it be static?
>> 
>> Signed-off-by: Andreea Hodea <hodea_andreea@xxxxxxxxx>
> 
> Applied, thanks.

I had to revert, did you even try to compile the driver after
this change?

The symbol is refenced by DbgRegister() calls in diddfunc.c, and
a very simple grep would have shown that to you.

Please do not just blindly try to fix checkpatch warnings.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/