Re: BUG_ON(nd->inode != parent->d_inode);

[Linus Torvalds]

On Fri, Mar 8, 2013 at 6:03 PM, Dave Jones <davej@xxxxxxxxxx> wrote:
>
> existing pathname + 'a' = fine.
>
> existing pathname + '/' + 'a' = boom.

Good.

> Looks like if I do this..
>
>        if (isdigit(newpath[len]) != 0) {
>                 newpath[len] = '/';
>                newpath[len+1] = 'A';
>                newpath[len+2] = 0;
>
> no bug.

Well, but that will never trigger. newpath[len] will always be NUL, so
you just disabled things entirely. Use "len-1".

So I don't think that did what you meant it to do.

            Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/