Re: [PATCH] HID: holtek: Holtek devices depends on USB_HID

[Randy Dunlap]

On 03/08/13 13:00, Jiri Kosina wrote:
> On Fri, 8 Mar 2013, Randy Dunlap wrote:
> 
>>> In the HID drivers tranport cleanup series, I removed the dependency
>>> between hid-holtek and usbhid. This was wrong as hid-holtek.c relies
>>> extensively on usb calls.
>>>
>>> This fixes compilation error when CONFIG_USB_SUPPORT is not enabled.
>>>
>>> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
>>
>> Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>>
>>
>> but hid-multitouch build still fails (on 3.9-rc1) when USB_SUPPORT is not enabled:
> 
> Are you sure about 3.9-rc1? It has USB_HID dependency for HID_MUTLTIOUCH, 
> hence that shouldn't be a problem.

You are correct.  I was testing 3.9-rc1 + mmotm, where the latter contains
some incorrect HID patches (from linux-next).

Thanks.

> There used to be a problem in linux-next, but that should be fixed by 
> 4ba25d3f87 ("HID: multitouch: remove last usb dependency"), which I have 
> pushed out yesterday.
> 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/