Re: [PATCH 1/1 v5] pwm_bl: Add support for backlight enable regulator

[Thierry Reding]

On Thu, Mar 07, 2013 at 01:16:08PM -0800, Andrew Chew wrote:
> The backlight enable regulator is specified in the device tree node for
> backlight.
> 
> Signed-off-by: Andrew Chew <achew@xxxxxxxxxx>

This looks good in general. I'd like to see Alex' comment addressed and
perhaps the commit message shouldn't be device tree specific, since the
same can be done with legacy board setup code. It would be nice if it'd
mention something about why the regulator is added.

Thierry

Attachment: pgp00000.pgp
Description: PGP signature