Re: [PATCH] kbuild: Fix destination-y for installed headers

From: Michal Marek
Date: Fri Feb 22 2013 - 05:50:44 EST


On Sat, Feb 02, 2013 at 11:18:35AM +0100, Jesper Nilsson wrote:
> Commit 10b63956fce7f369cc37fd4d994f09bd5203efe4 which plumbed in UAPI
> broke the destination-y functionality of scripts/Makefile.headersinst.
>
> The variable destination-y is used in a := assignment and so is expanded at
> declaration time, and the include of the Kbuild fragments that set
> destination-y to something is after this time, so it now always expands empty.
>
> There are no in-tree users of destination-y, but it allows any
> Kbuild-fragment to redirect where headers are installed.
>
> Just move the assignment of the variable that uses it below the include
> of the Kbuild fragment.
>
> Signed-off-by: Jesper Nilsson <jesper.nilsson@xxxxxxxx>
> Cc: Michal Marek <mmarek@xxxxxxx>
> Cc: David Howells <dhowells@xxxxxxxxxx>
> ---
> Makefile.headersinst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git scripts/Makefile.headersinst scripts/Makefile.headersinst

I applied your patch to kbuild.git#kbuild, but please send -p1 patches
next time.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/