Re: [PATCH] regulator: tps6586x: Having slew rate settings for otherthan SM0/1 is not fatal

From: Mark Brown
Date: Tue Feb 19 2013 - 15:07:21 EST


On Tue, Feb 19, 2013 at 12:32:50PM -0700, Stephen Warren wrote:
> On 02/19/2013 11:26 AM, Mark Brown wrote:

> > - what he's saying is that the error handling here seems
> > excessive.

> Why shouldn't the driver return an error if it's asked to do something
> that's impossible?

I'm having a hard time caring too much to be honest. On the one hand it
means that if that feature gets added for some reason new DTs won't work
on older kernels, on the other hand perhaps the hardware doesn't support
doing this at all.

Attachment: signature.asc
Description: Digital signature