Re: [PATCH 2/3] stop_machine: dequeue work before signal completion

[Hillf Danton]

On Thu, Feb 7, 2013 at 10:29 AM, Tejun Heo <tj@xxxxxxxxxx> wrote:
> On Wed, Feb 6, 2013 at 6:21 PM, Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
>>> Why does this matter?  It's inside spinlock.  What's being made better
>>> by this change?
>>
>> IIUC the work should be deleted from the list, otherwise it'd trigger
>> BUG_ON when the cpu gets online again.
>
> Ah, okay, the original code was missing list_del_init(), so we end up
> with trashy work list if CPU goes down while there are pending work
> items which will trigger BUG_ON() later when the CPU comes back on.
>
> Hillf, can you please redo the patch description?

Sure, thanks;)
Hillf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/