Re: [PATCH 1/1] depmod: pass -P $CONFIG_SYMBOL_PREFIX

[Mike Frysinger]

On Tuesday 05 February 2013 05:33:19 James Hogan wrote:
> On 03/02/13 06:17, Mike Frysinger wrote:
> > On Thursday 31 January 2013 04:41:43 James Hogan wrote:
> >> --- a/Makefile
> >> +++ b/Makefile
> >> 
> >> +ifneq ($(patsubst "%",%,$(CONFIG_SYMBOL_PREFIX)),)
> >> +  depmod_args = -P $(patsubst "%",%,$(CONFIG_SYMBOL_PREFIX))
> >> +endif
> >> ...
> >>  # Run depmod only if we have System.map and depmod is executable
> >>  quiet_cmd_depmod = DEPMOD  $(KERNELRELEASE)
> >>        cmd_depmod = $(CONFIG_SHELL) $(srctree)/scripts/depmod.sh
> >>        $(DEPMOD) \
> >> -                   $(KERNELRELEASE)
> >> +                   $(KERNELRELEASE) $(depmod_args)
> > 
> > scripts/Makefile.lib just does:
> > 	ifdef CONFIG_SYMBOL_PREFIX
> > 
> > so you should do the same
> 
> arch/openrisc/Kconfig now defines SYMBOL_PREFIX as "", so this isn't
> sufficient (arguably it probably shouldn't be defined empty like that?)

yes, that should simply be deleted

> > that said, cmd_depmod is just a shell command.  and you're running
> > another script helper (depmod.sh).  how about passing it unconditionally
> > ?
> > 
> > 	cmd_depmod = ... -P "$(CONFIG_SYMBOL_PREFIX)"
> > 
> > since the default will be "no prefix", using -P "" is the same thing.
> 
> Yep, I could do this, but depmod.sh would need modifying to drop it if
> the prefix is empty, otherwise you get the following from depmod:
> FATAL: -P only takes a single char
> 
> I don't mind adding that, but what do you think?

i mean depmod.sh should only pass -P to depmod if the arg is non-empty
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.