Re: [PATCH] drm/i915: Treat crtc->mode.clock == 0 as disabled

[Daniel Vetter]

On Mon, Jan 07, 2013 at 10:11:40AM +0000, Chris Wilson wrote:
> Prevent a divide-by-zero by consistently treating an 'active' CRTC
> without a mode set as actually disabled.
> 
> This looks to have been first introduced with
> 
> commit 24929352481f085c5f85d4d4cbc919ddf106d381
> Author: Daniel Vetter <daniel.vetter@xxxxxxxx>
> Date:   Mon Jul 2 20:28:59 2012 +0200
> 
>     drm/i915: read out the modeset hw state at load and resume time
> 
> but then combined with
> 
> commit b0a2658acb5bf9ca86b4aab011b7106de3af0add
> Author: Daniel Vetter <daniel.vetter@xxxxxxxx>
> Date:   Tue Dec 18 09:37:54 2012 +0100
> 
>     drm/i915: don't disable disconnected outputs
> 
> it finally started oopsing.
> 
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Reported-and-tested-by: Alexey Zaytsev <alexey.zaytsev@xxxxxxxxx>
> Tested-by: Sedat Dilek <sedat.dilek@xxxxxxxxx>
> Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
> Cc: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx

Picked up for -fixes, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/