Re: [PATCH v7u1 06/31] x86, 64bit, realmode: use init_level4_pgt toset trapmoline_pgt directly

From: Sakkinen, Jarkko
Date: Sat Jan 05 2013 - 04:59:14 EST


On Fri, 2013-01-04 at 14:01 -0800, Yinghai Lu wrote:
> On Fri, Jan 4, 2013 at 9:18 AM, Sakkinen, Jarkko
> <jarkko.sakkinen@xxxxxxxxx> wrote:
> > On Thu, 2013-01-03 at 16:48 -0800, Yinghai Lu wrote:
> >> with #PF handler way to set early page table, level3_ident will go away with
> >> 64bit native path.
> >>
> >> So just use entries in init_level4_pgt to set them in tramopline_pgt
> >>
> >> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
> >> Cc: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxx>
> >
> > Acked-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxx>
>
> Thanks.
>
> updated the patch, and would save some time for HPA.

Sure. They look fine to me. Larger patch does only code
reordering from realmode code point of view and smaller
patch initializes trampoline_gdt essentially with the
same values as before so I don't see why these patches
would break anything.

But let's wait for hpa comments.

/Jarkko
èº{.nÇ+‰·Ÿ®‰­†+%ŠËlzwm…ébëæìr¸›zX§»®w¥Š{ayºÊÚë,j­¢f£¢·hš‹àz¹®w¥¢¸ ¢·¦j:+v‰¨ŠwèjØm¶Ÿÿ¾«‘êçzZ+ƒùšŽŠÝj"ú!¶iO•æ¬z·švØ^¶m§ÿðà nÆàþY&—