Re: [PATCH] platform: Fix platform device resource linking

From: Pantelis Antoniou
Date: Thu Jan 03 2013 - 17:43:40 EST


Hi Greg,

On Jan 4, 2013, at 12:40 AM, Greg Kroah-Hartman wrote:

> On Fri, Jan 04, 2013 at 12:31:10AM +0200, Pantelis Antoniou wrote:
>> Platform device removal uncovered a number of problems with
>> the way resources are handled in the core platform code.
>>
>> Resources now form child/parent linkages and this requires
>> proper linking of the resources. On top of that the OF core
>> directly creates it's own platform devices. Simplify things
>> by providing helper functions that manage the linking properly.
>>
>> Two functions are provided:
>>
>> platform_device_link_resources(), which links all the
>> linkable resources (if not already linked).
>>
>> and platform_device_unlink_resources(), which unlinks all the
>> resources.
>
> Who would call these functions, and why?
>
> And why have we never seen problems with removing platform devices
> previously?
>

Have you tried removing devices that were created via DT and
not using platform data?

> thanks,
>
> greg k-h

Regards

-- Pantelis

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/