Re: [PATCH 19/29] batman-adv: fix random jitter calculation

[Antonio Quartulli]

On Mon, Dec 24, 2012 at 11:14:06AM +0900, Akinobu Mita wrote:
> batadv_iv_ogm_emit_send_time() attempts to calculates a random integer
> in the range of 'orig_interval +- BATADV_JITTER' by the below lines.
> 
>         msecs = atomic_read(&bat_priv->orig_interval) - BATADV_JITTER;
>         msecs += (random32() % 2 * BATADV_JITTER);
> 
> But it actually gets 'orig_interval' or 'orig_interval - BATADV_JITTER'
> because '%' and '*' have same precedence and associativity is
> left-to-right.
> 
> This adds the parentheses at the appropriate position so that it matches
> original intension.
> 
> Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
> Cc: Marek Lindner <lindner_marek@xxxxxxxx>
> Cc: Simon Wunderlich <siwu@xxxxxxxxxxxxxxxxxx>
> Cc: Antonio Quartulli <ordex@xxxxxxxxxxxxx>
> Cc: b.a.t.m.a.n@xxxxxxxxxxxxxxxxxxx
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx
> ---

Acked-by: Antonio Quartulli <ordex@xxxxxxxxxxxxx>

But I would suggest to apply this change to net, since it is a fix.

Cheers,


-- 
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

Attachment: pgp00000.pgp
Description: PGP signature