Re: [PATCH 2/3] perf tool: Add support to include non architecturalevent aliases

From: Jiri Olsa
Date: Tue Dec 18 2012 - 02:41:39 EST


On Tue, Dec 18, 2012 at 10:12:03AM +0900, Namhyung Kim wrote:
> Hi Jiri,
>
> On Mon, 17 Dec 2012 14:37:04 +0100, Jiri Olsa wrote:
> > Adding support to parse non architectural event aliases
> > for given cpu. These aliases will be provided as 'events'
> > directory like architectural ones provided by kernel.
> >
> [snip]
> > +
> > +$(OUTPUT)$(OUTPUT)arch/$(ARCH)/util/pmu.o: $(OUTPUT)arch/$(ARCH)/util/pmu.c $(OUTPUT)PERF-CFLAGS
>
> Double OUTPUT ? ;)

humm, yes ;-)

>
>
> > + $(QUIET_CC)$(CC) -o $@ -c $(ALL_CFLAGS) \
> > + '-DPERF_EXEC_PATH="$(perfexecdir_SQ)"' \
> > + '-DPREFIX="$(prefix_SQ)"' \
> > + $<
> [snip]
> > +static int cpu_aliases(struct list_head *head)
> > +{
> > + unsigned vendol, model;
>
> s/vendol/vendor/ ?

http://en.wikipedia.org/wiki/The_13th_Warrior
... 'Wendol', fiends who come with the mist to kill and eat human flesh ...

;-)

thanks
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/