Re: [PATCH] staging/serqt_usb2: Refactor qt_status_change_check() in serqt_usb2.c

From: YAMANE Toshiaki
Date: Fri Nov 30 2012 - 07:53:47 EST


On Fri, Nov 30, 2012 at 5:25 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> On Thu, Nov 29, 2012 at 06:10:26PM -0800, Greg Kroah-Hartman wrote:
>> On Thu, Nov 29, 2012 at 01:57:56PM +0900, YAMANE Toshiaki wrote:
>> >
>> > - ProcessLineStatus(qt_port, data[i + 3]);
>> > -
>> > i += 3;
>> > + ProcessLineStatus(qt_port, data[i]);
>>
>> I think you just changed the logic in this function, didn't you?
>
> This should be ok. The i += 3 was there in the original, it's just
> moved up a line.

Thanks for your kindness reply.

But please discard this patch.
Let me consider this patch again.


Regards,

YAMANE Toshiaki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/