Re: [PATCH 245/270] USB: mct_u232: fix broken close

From: Greg Kroah-Hartman
Date: Thu Nov 29 2012 - 20:23:10 EST


On Tue, Nov 27, 2012 at 04:15:51PM +0000, Ben Hutchings wrote:
> On Mon, 2012-11-26 at 14:58 -0200, Herton Ronaldo Krzesinski wrote:
> > 3.5.7u1 -stable review patch. If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Johan Hovold <jhovold@xxxxxxxxx>
> >
> > commit 5260e458f5eff269a43e4f1e9c47186c57b88ddb upstream.
> >
> > Make sure generic close is called at close.
> >
> > The driver relies on the generic write implementation but did not call
> > generic close.
> >
> > Note that the call to kill the read urb is not redundant, as mct_u232
> > uses an interrupt urb from the second port as the read urb and that
> > generic close therefore fails to kill it.
> >
> > Compile-only tested.
> >
> > Signed-off-by: Johan Hovold <jhovold@xxxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@xxxxxxxxxxxxx>
> [...]
>
> This is missing on 3.4; the version I used for 3.2 (attached) should be
> applicable.

Thanks, that works.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/