Re: [PATCH] char/tpm: Use true and false for bools

From: Kent Yoder
Date: Thu Nov 29 2012 - 11:08:03 EST


On Thu, Nov 29, 2012 at 01:42:47AM +0100, Peter Huewe wrote:
> Am Donnerstag, 29. November 2012, 01:25:19 schrieb Al Viro:
> > On Thu, Nov 29, 2012 at 01:20:37AM +0100, Peter Huewe wrote:
> > > - itpm = (probe == 0) ? 0 : 1;
> > > + itpm = (probe == 0) ? false : true;
> >
> > Charming. Not that original had been better, but...
> Yeah. Sorry it's late.
> The tpm subsection has a lot of nice suprises.

:-) I'd prefer

itpm = !!probe;

Now I don't have to go look up what the possible return values of
probe_itpm() are...

Kent

> I changed it to itpm = probe; which is equivalent here and sent out a v2.
> I'll probably rewrite that code section anytime soon.
>
> Thanks for noticing.
> Peter
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/