Re: [PATCH, resend] kfifo: initialize fifo accordingly to C99standard

From: Andrew Morton
Date: Wed Nov 28 2012 - 20:51:29 EST


On Wed, 21 Nov 2012 16:31:11 +0200
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

> When build a kernel with "make W=1" we will get a warning about missing
> initializer. It comes from kfifo usage style. The DEFINE_KFIFO macro doesn't
> initialize the buf[] field of the fifo structure. So, using C99 style helps in
> such case.

This doesn't actually work:

drivers/pci/pcie/aer/aerdrv_core.c:573: error: unknown field 'kfifo' specified in initializer
drivers/pci/pcie/aer/aerdrv_core.c:573: error: unknown field 'in' specified in initializer
drivers/pci/pcie/aer/aerdrv_core.c:573: warning: missing braces around initializer
drivers/pci/pcie/aer/aerdrv_core.c:573: warning: (near initialization for '(anonymous).<anonymous>.kfifo')
drivers/pci/pcie/aer/aerdrv_core.c:573: error: unknown field 'out' specified in initializer

gcc-4.4.4.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/