Re: [PATCH] uio.c: Fix warning: 'ret' might be used uninitialized

[Hans J. Koch]

On Wed, Nov 28, 2012 at 10:58:32AM +0200, Vitalii Demianets wrote:
> On Wednesday 28 November 2012 00:43:41 Hans J. Koch wrote:
> > 
> > Thanks, good catch, but why don't you simply do this:
> > 
> 
> Just a matter of personal preference.

Your patch: 1 files changed, 12 insertions(+), 4 deletions(-)
My patch: 1 files changed, 1 insertions(+), 1 deletions(-)

Both achieve exactly the same. That's not a matter of personal
preference, that's the difference between a working solution and
a good solution. In the kernel, we want the latter.

> As a maintainer you can apply either 
> patch you want. I guess you would prefer your approach and I have no 
> objections to that :)

That's not the right kind of comment. Don't make it a habit.

Thanks,
Hans

> 
> > 
> > >From 228445996bb75a44d16b6237eca6a0916d9b2d7e Mon Sep 17 00:00:00 2001
> > From: "Hans J. Koch" <hjk@xxxxxxxxxxxx>
> > Date: Tue, 27 Nov 2012 23:38:00 +0100
> > Subject: [PATCH] uio: Fix warning: 'ret' might be used uninitialized
> > 
> > In two cases, the return value variable "ret" can be undefined.
> > 
> > Signed-off-by: Hans J. Koch <hjk@xxxxxxxxxxxx>
> > ---
> >  drivers/uio/uio.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
> > index 5110f36..fc60e35 100644
> > --- a/drivers/uio/uio.c
> > +++ b/drivers/uio/uio.c
> > @@ -263,7 +263,7 @@ static struct class uio_class = {
> >   */
> >  static int uio_dev_add_attributes(struct uio_device *idev)
> >  {
> > -	int ret;
> > +	int ret = -ENOMEM;
> >  	int mi, pi;
> >  	int map_found = 0;
> >  	int portio_found = 0;
> 
> 
> 
> -- 
> With Best Regards,
> Vitalii Demianets
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/