Re: [PATCH] mtd cs553x_nand: Initialise ecc.strength before nand_scan()

From: Mike Dunn
Date: Tue Nov 27 2012 - 13:23:59 EST


On 11/21/2012 08:08 PM, Brian Norris wrote:
> On Wed, Nov 21, 2012 at 3:42 PM, Nathan Williams <nathan@xxxxxxxxxxxxxxx> wrote:
>> Loading cs553x_nand with Hynix H27U1G8F2BTR NAND flash causes this bug:
>>
>> kernel BUG at drivers/mtd/nand/nand_base.c:3345!
> ...
>> Initialising ecc.strength before the call to nand_scan() fixes this.
>
> Acked-by: Brian Norris <computersforpeace@xxxxxxxxx>


Acked-by: Mike Dunn <mikedunn@xxxxxxxxxxx>


>
> BTW, I made a quick read through of the other NAND drivers to look for
> similar errors. I think this is the only one where the only
> ecc.strenght initialization occurred after the nand_scan() or
> nand_scan_tail() call.


Thanks for that Brian. I thought I did this when another driver had a similiar
problem a while back. Maybe I just intended to :(

Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/