Re: [patch 7/7] fs, notify: Add procfs fdinfo helper v6

[Andrew Morton]

On Wed, 14 Nov 2012 19:19:44 +0400
Cyrill Gorcunov <gorcunov@xxxxxxxxxx> wrote:

> This allow us to print out fsnotify details such as
> watchee inode, device, mask and optionally a file handle.

This helps the compiler quite a lot:

--- a/fs/notify/fdinfo.c~fs-notify-add-procfs-fdinfo-helper-v7-fix
+++ a/fs/notify/fdinfo.c
@@ -26,13 +26,13 @@ static int show_fdinfo(struct seq_file *
 	struct fsnotify_mark *mark;
 	int ret = 0;
 
-	spin_lock(&group->mark_lock);
+	mutex_lock(&group->mark_mutex);
 	list_for_each_entry(mark, &group->marks_list, g_list) {
 		ret = show(m, mark);
 		if (ret)
 			break;
 	}
-	spin_unlock(&group->mark_lock);
+	mutex_unlock(&group->mark_mutex);
 	return ret;
 }
 

But I rather worry that the code which you sent clearly wasn't the code
which you tested.  Please retest and confirm that I now have the correct
code?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/