Re: [PATCH 1/2] ASoC: davinci-mcasp: Add pinctrl support

From: Mark Brown
Date: Mon Nov 26 2012 - 06:45:05 EST


On Thu, Nov 22, 2012 at 09:34:58AM +0530, Hebbar, Gururaja wrote:

> + pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> + if (IS_ERR(pinctrl))
> + dev_warn(&pdev->dev,
> + "pins are not configured from the driver\n");

Since the driver is happy to continue without the pins why is it
bothering requesting them in the first place? In other words, this
should be a hard error.

Attachment: signature.asc
Description: Digital signature