Re: [PATCH 00/46] staging: line6: drop MIDI state sysfs attrs

[Markus Grabner]

Am Donnerstag, 22. November 2012, 21:08:55 schrieb Stefan Hajnoczi:
> On Thu, Nov 22, 2012 at 8:58 PM, Greg Kroah-Hartman
> 
> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > On Thu, Nov 22, 2012 at 08:48:39PM +0100, Stefan Hajnoczi wrote:
> >> Markus and I have discussed the MIDI processing that currently happens in
> >> the line6 driver.  This stuff really belongs in userspace where a
> >> library or utility can use ALSA MIDI APIs to control the device.  Moving
> >> MIDI processing to userspace has several benefits:
> >> 
> >> 1. The driver only handles PCM and MIDI I/O.  This means less kernel
> >> code.
> >> 
> >> 2. A large number of sysfs attributes can be removed.  These attributes
> >> exposed>> 
> >>    MIDI state and driver code was necessary to sync and manage this
> >>    state.
> >> 
> >> 3. It's easier for userspace to control the device, try out new MIDI
> >> commands,>> 
> >>    etc when the driver acts as a dumb transport.
> >> 
> >> This patch series removes the sysfs attributes and then removes the state
> >> behind those attributes.  I have tried to make small incremental changes
> >> that can be reviewed easily.
> > 
> > Very nice, I'll queue these up on Monday, very good work, thanks so much
> > for doing this.
> 
> Thanks!  I hope Markus has a chance to review and/or test these
> changes first - he knows generally what I'm up too but should have the
> final word on details.
I just applied all patches and did a quick check with the PODxt Live. The 
following features are still working:
*) the user space code which receives and interprets (at least some) MIDI 
messages from the device
*) ALSA playback
*) ALSA volume and monitor controls

I will have a look at the Variax and TonePort later.

	Kind regards,
		Markus

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/