Re: [PATCH] of/address: sparc: Declare of_iomap as an extern function for sparc again

[Grant Likely]

Cc'ing stable since this should go into previous kernels too.

g.


Grant Likely <grant.likely@xxxxxxxxxxxx> wrote:

>On Fri, 23 Nov 2012 14:21:10 -0500 (EST), David Miller
><davem@xxxxxxxxxxxxx> wrote:
>> From: Andreas Larsson <andreas@xxxxxxxxxxx>
>> Date: Fri, 23 Nov 2012 12:24:09 +0100
>> 
>> > This bug-fix makes sure that of_iomap is defined extern for sparc
>so that the
>> > sparc-specific implementation of_iomap is once again used when
>including
>> > include/linux/of_address.h in a sparc context. OF_GPIO that is now
>available for
>> > sparc relies on this.
>> > 
>> > The bug was inadvertently introduced in a850a75, "of/address: add
>empty static
>> > inlines for !CONFIG_OF", that added a static dummy inline for
>of_iomap when
>> > !CONFIG_OF_ADDRESS. However, CONFIG_OF_ADDRESS is never defined for
>sparc, but
>> > there is a sparc-specific implementation
>/arch/sparc/kernel/of_device_common.c.
>> > 
>> > This fix takes the same approach as 0bce04b that solved the
>equivalent problem
>> > for of_address_to_resource.
>> > 
>> > Signed-off-by: Andreas Larsson <andreas@xxxxxxxxxxx>
>> 
>> Grant, can you possibly merge this to Linus while I'm travelling?
>> That would help me a lot.
>
>Yup, I'm doing it right now.
>
>g.

-- 
Grant Likely, P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/