Re: [PATCH 1/8] DMA: PL330: use prefix in reg names to build under x86

[Davide Ciminaghi]

On Fri, Nov 23, 2012 at 09:21:44PM +0530, viresh kumar wrote:
> On Fri, Nov 23, 2012 at 8:38 PM, Davide Ciminaghi <ciminaghi@xxxxxxxxx> wrote:
> > From: Alessandro Rubini <rubini@xxxxxxxxx>
> >
> > This driver would not compile if ARM_AMBA is selected under x86,
> > because "CS" and "DS" are already defined there.  But AMBA
> > is used in the x86 world by a PCI-to-AMBA bridge, to be submitted.
> >
> > The patch adds the "PL330_" prefix to all register and bit fields,
> > so it can be built by randomconfig after ARM_AMBA appears within x86.
> >
> > Signed-off-by: Alessandro Rubini <rubini@xxxxxxxxx>
> > Acked-by: Giancarlo Asnaghi <giancarlo.asnaghi@xxxxxx>
> 
> Hi Davide,
> 
> Its impossible to review due to obvious reasons :)
> 
> Though git provides an option to people to review such stuff easily.
> 
> git diff HEAD^.. --word-diff
> 
> and HEAD being the commit in discussion.
> 
> Problem, is people reviewing it need to apply it and not everybody
> can do that. Don't know if adding this diff after the three --- line,
> which form the non-commit log would be the right solution ?
>
Hi,

I tried that, but the resulting patch does not apply:

$ git checkout -b pl330_test next-20121115
Switched to a new branch 'pl330_test'

$ git format-patch --word-diff 5f1e3c5~..5f1e3c5

$ cat 0001-DMA-PL330-use-prefix-in-reg-names-to-build-under-x86.patch