Re: [PATCH] gpio: stmpe: Add DT support for stmpe gpio

[Shiraz Hashim]

On Fri, Nov 23, 2012 at 12:14:13PM +0000, Lee Jones wrote:
> > >> +             if (np)
> > >> +                     of_property_read_u32(np, "st,norequest-mask",
> > >> +                                     &pdata->norequest_mask);
> > >
> > > Can you explain to me what this does?
> > 
> > You mean pdata->norequest_mask?  It marks few gpios as unusable.
> > Because these pads might be used by other blocks of stmpe.
> 
> I'm not sure if that should be set with DT or not.
> 
> Second opinion anyone?

This is a board dependent parameter which just informs gpio driver
about pins, which must not be requested. It may happen for a stmpe
variant where such gpio pins are multiplexed with some other
function.

Hence it must be part of DT itself.

--
regards
Shiraz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/