Re: [PATCH v2] ASoC: fsl: fix miscompilation of snd-soc-imx-pcm

[Mark Brown]

On Fri, Nov 23, 2012 at 10:12:13AM +0100, Lothar Waßmann wrote:
> Due to a broken make rule, sound/soc/fsl/imx-pcm-dma.c or
> sound/soc/fsl/imx-pcm-fiq.c (whatever is selected via Kconfig) will
> not be compiled into imx-pcm.o when building as module, i.e.:

What I've been trying to do is get you to tell me what the problem is
with the Makefile rule, it's really not clear to me what the issue is or
why your change is better.  I can see the practical results but nothing
about how they came to be which makes it very hard to tell if this is a
good fix.

This is a common issue with stuff you send, there's lots of analysis
missing so it's hard to understand the thought process behind the
change.

Attachment: signature.asc
Description: Digital signature