Re: [PATCH] regulator: max8925: fix compiler warnings

From: Mark Brown
Date: Thu Nov 22 2012 - 20:41:28 EST


On Thu, Nov 22, 2012 at 10:11:06AM +0800, Qing Xu wrote:

> - int i, regulator_idx;
> + int i;
> + int regulator_idx = 0;

This sort of fix is rarely good without some analysis as to why this is
a sensible initialisation to do, just unconditionally initialising may
be masking a real issue in the control flow which the compiler has
identified.

Attachment: signature.asc
Description: Digital signature