Re: [Suggestion] drivers/char: in hpet.c, check for hdp->hd_nirqs

[Greg KH]

On Thu, Nov 22, 2012 at 12:50:32PM +0800, Chen Gang wrote:
> Hello Arnd Bergmann, Greg Kroah-Hartman
> 
>   in drivers/char/hpet.c:1009
>     I suggest to add check for hdp->hd_nirqs whether equal or larger than 32 (HPET_MAX_TIMERS)
>       the type of irqp->interrupt_count is u8 (include/acpi/acrestyp.h:349)
>       the type of hdp->hd_irq is "unsigned int hd_irq[HPET_MAX_TIMERS]" (include/linux/hpet.h:99)
>       #define HPET_MAX_TIMERS (32) (include/linux/hpet.h:38)
> 
>   additional information:
>     acpi_register_gsi() not check the boundaries of how many irqs (at least, unlimited for u8).
>     maybe (only maybe) the irqp->interrupt_count is always less than 32 by hardware limitation.
>     I do not know whether it is a bug, so as a suggestion.

Care to send a patch that implements this?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/