Re: [ 35/83] ARM: imx: ehci: fix host power mask bit

[Michael D. Burkey]

This patch is definitely needed -- it is obviously setting the wrong bit --  
but I am still doing testing to see what other complications may arise from 
actually setting the RIGHT bit (i.e. I've seen some odd results so far and 
suspect some other code may have been changed historically to account for 
the wrong behaviour this bit was causing).

We're currently on vacation for Thanksgiving over here in the USA and I 
won't be back in the office til next week.

If you would, hold off on adding the patch to the stable kernel until I have 
a bit more time to check out a couple of things.

Thanks,
Michael Burkey

----- Original Message ----- 
From: "Greg Kroah-Hartman" <gregkh@xxxxxxxxxxxxxxxxxxx>
To: <linux-kernel@xxxxxxxxxxxxxxx>; <stable@xxxxxxxxxxxxxxx>
Cc: "Greg Kroah-Hartman" <gregkh@xxxxxxxxxxxxxxxxxxx>; 
<alan@xxxxxxxxxxxxxxxxxxx>; "Michael Burkey" <mdburkey@xxxxxxxxx>; 
"Christoph Fritz" <chf.fritz@xxxxxxxxxxxxxx>; "Eric BÃnard" 
<eric@xxxxxxxxxx>; "Sascha Hauer" <s.hauer@xxxxxxxxxxxxxx>
Sent: Wednesday, November 21, 2012 7:41 PM
Subject: [ 35/83] ARM: imx: ehci: fix host power mask bit


> 3.6-stable review patch.  If anyone has any objections, please let me 
> know.
>
> ------------------
>
> From: Christoph Fritz <chf.fritz@xxxxxxxxxxxxxx>
>
> commit 3d5e2abe6e265acc5e1fda810301243e9bac92b2 upstream.
>
> This patch sets HPM (Host power mask bit) to bit 16 according to i.MX
> Reference Manual. Falsely it was set to bit 8, but this controls pull-up
> Impedance.
>
> Reported-by: Michael Burkey <mdburkey@xxxxxxxxx>
> Signed-off-by: Christoph Fritz <chf.fritz@xxxxxxxxxxxxxx>
> Acked-by: Eric BÃnard <eric@xxxxxxxxxx>
> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
> ---
> arch/arm/mach-imx/ehci-imx25.c |    2 +-
> arch/arm/mach-imx/ehci-imx35.c |    2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> --- a/arch/arm/mach-imx/ehci-imx25.c
> +++ b/arch/arm/mach-imx/ehci-imx25.c
> @@ -30,7 +30,7 @@
> #define MX25_H1_SIC_SHIFT 21
> #define MX25_H1_SIC_MASK (0x3 << MX25_H1_SIC_SHIFT)
> #define MX25_H1_PP_BIT (1 << 18)
> -#define MX25_H1_PM_BIT (1 << 8)
> +#define MX25_H1_PM_BIT (1 << 16)
> #define MX25_H1_IPPUE_UP_BIT (1 << 7)
> #define MX25_H1_IPPUE_DOWN_BIT (1 << 6)
> #define MX25_H1_TLL_BIT (1 << 5)
> --- a/arch/arm/mach-imx/ehci-imx35.c
> +++ b/arch/arm/mach-imx/ehci-imx35.c
> @@ -30,7 +30,7 @@
> #define MX35_H1_SIC_SHIFT 21
> #define MX35_H1_SIC_MASK (0x3 << MX35_H1_SIC_SHIFT)
> #define MX35_H1_PP_BIT (1 << 18)
> -#define MX35_H1_PM_BIT (1 << 8)
> +#define MX35_H1_PM_BIT (1 << 16)
> #define MX35_H1_IPPUE_UP_BIT (1 << 7)
> #define MX35_H1_IPPUE_DOWN_BIT (1 << 6)
> #define MX35_H1_TLL_BIT (1 << 5)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/