Re: [PATCH v2] dmatest: Fix NULL pointer dereference on ioat

From: viresh kumar
Date: Thu Nov 22 2012 - 13:59:32 EST


On Wed, Nov 14, 2012 at 8:17 AM, viresh kumar <viresh.kumar@xxxxxxxxxx> wrote:
> On Mon, Nov 12, 2012 at 4:33 AM, Jon Mason <jon.mason@xxxxxxxxx> wrote:
>> device_control is an optional and not implemented in all DMA drivers.
>> Any calls to these will result in a NULL pointer dereference. dmatest
>> makes two of these calls when completing the kernel thread and removing
>> the module. These are corrected by calling the dmaengine_device_control
>> wrapper and checking for a non-existant device_control function pointer
>> there.
>>
>> Signed-off-by: Jon Mason <jon.mason@xxxxxxxxx>
>> CC: Vinod Koul <vinod.koul@xxxxxxxxx>
>> CC: Dan Williams <djbw@xxxxxx>

> Reviewed-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

Vinod/Dan: I couldn't find this patch and
https://patchwork.kernel.org/patch/1720971/
in you trees. Are you pushing them for 3.8?

--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/