Re: [RFT PATCH v1 1/5] mm: introduce new field "managed_pages" tostruct zone

[Andrew Morton]

On Wed, 21 Nov 2012 22:36:56 +0800
Jiang Liu <liuj97@xxxxxxxxx> wrote:

> > void mod_zone_managed_pages(struct zone *zone, signed long delta)
> > {
> > 	WARN_ON(system_state != SYSTEM_BOOTING &&
> > 		!is_locked_memory_hotplug());
> > 	zone->managed_pages += delta;
> > }
> This seems a little overhead because __free_pages_bootmem() is on the hot path
> and will be called many times at boot time.

Maybe, maybe not.  These things are measurable so let's not just guess.

But I'm not really recommending that we do this - there are all sorts
of things we *could* check and warn about, but we don't.  Potential
errors in this area don't seem terribly important.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/