Re: [PATCH] ARM: exynos: add UART3 to DEBUG_LL ports

From: Doug Anderson
Date: Wed Nov 21 2012 - 11:58:24 EST


On Tue, Nov 20, 2012 at 11:29 PM, Olof Johansson <olof@xxxxxxxxx> wrote:
>
> On Tue, Nov 20, 2012 at 02:48:58PM -0800, Doug Anderson wrote:
> > From: Olof Johansson <olof@xxxxxxxxx>
> >
> > UART3 is used for debugging on exynos5250-snow.
> >
> > [dianders: cleaned commit message.]
> >
> > Signed-off-by: Olof Johansson <olof@xxxxxxxxx>
> > Signed-off-by: Doug Anderson <dianders@xxxxxxxxxxxx>
>
> >
> > ---
> > arch/arm/Kconfig.debug | 11 +++++++++++
> > arch/arm/plat-samsung/Kconfig | 1 +
> > 2 files changed, 12 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> > index 33a8930..35ba7dc 100644
> > --- a/arch/arm/Kconfig.debug
> > +++ b/arch/arm/Kconfig.debug
> > @@ -355,6 +355,17 @@ choice
> > The uncompressor code port configuration is now handled
> > by CONFIG_S3C_LOWLEVEL_UART_PORT.
> >
> > + config DEBUG_S3C_UART3
> > + depends on PLAT_SAMSUNG
>
>
> Sorry, the reason I hadn't re-posted this is that Kukjin had proposed
> to protect users of <= 3 UART platforms to select it. An added "Depends
> on ARCH_EXYNOS4 || ARCH_EXYNOS5" should cover that. Can you add and
> repost, please?

Doh! I hadn't even noticed that you'd already posted this--I got mine
from the Chrome OS tree directly. Sorry about that...

I've added an && for ARCH_EXYNOS which seems reasonable. I left
PLAT_SAMSUNG as a depend though technically ARCH_EXYNOS does select
PLAT_SAMSUNG through a convoluted series of other config options.

-Doug
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/