Re: [PATCH 37/46] mm: numa: Add THP migration for the NUMA workingset scanning fault case.

From: Mel Gorman
Date: Wed Nov 21 2012 - 06:24:27 EST


On Wed, Nov 21, 2012 at 10:21:43AM +0000, Mel Gorman wrote:
> Note: This is very heavily based on a patch from Peter Zijlstra with
> fixes from Ingo Molnar, Hugh Dickins and Johannes Weiner. That patch
> put a lot of migration logic into mm/huge_memory.c where it does
> not belong. This version puts tries to share some of the migration
> logic with migrate_misplaced_page. However, it should be noted
> that now migrate.c is doing more with the pagetable manipulation
> than is preferred. The end result is barely recognisable so as
> before, the signed-offs had to be removed but will be re-added if
> the original authors are ok with it.
>
> Add THP migration for the NUMA working set scanning fault case.
>
> It uses the page lock to serialize. No migration pte dance is
> necessary because the pte is already unmapped when we decide
> to migrate.
>
> Signed-off-by: Mel Gorman <mgorman@xxxxxxx>
> ---
> include/linux/migrate.h | 16 ++++
> mm/huge_memory.c | 55 +++++++-----
> mm/internal.h | 2 +
> mm/migrate.c | 212 ++++++++++++++++++++++++++++++++++++++---------
> 4 files changed, 226 insertions(+), 59 deletions(-)
>

And now that I've released it I see that this almost certainly broke
memcg as the memcontrol.c bits are missing. I'll need to carry them
over.

--
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/