Re: [PATCH, v2] mm, numa: Turn 4K pte NUMA faults into effectivehugepage ones

From: Ingo Molnar
Date: Wed Nov 21 2012 - 03:12:36 EST



* Rik van Riel <riel@xxxxxxxxxx> wrote:

> >+}
> >+
> >+/*
> >+ * Add a simple loop to also fetch ptes within the same pmd:
> >+ */
>
> That's not a very useful comment. How about something like:
>
> /*
> * Also fault over nearby ptes from within the same pmd and vma,
> * in order to minimize the overhead from page fault exceptions
> * and TLB flushes.
> */

There's no TLB flushes here. But I'm fine with the other part so
I've updated the comment to say:

/*
* Also fault over nearby ptes from within the same pmd and vma,
* in order to minimize the overhead from page fault exceptions:
*/

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/