Re: [PATCH v2 03/13] x86: Add macro for 64bit entry startup_64

[H. Peter Anvin]

I don't see any point in three flags here.  Let's stick to one flag; then it fits in the existing boot_flags field.

Yinghai Lu <yinghai@xxxxxxxxxx> wrote:

>On Mon, Nov 19, 2012 at 4:39 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
>> On Mon, Nov 19, 2012 at 3:55 PM, H. Peter Anvin <hpa@xxxxxxxxx>
>wrote:
>>> We probably should add a flag for those, but that is more of a
>boot_flag...
>>
>> kernel_cap_bits:
>> RAMDISK_ABOVE_4G  = (1<<0)
>> KERNEL_ABOVE_4G =(1<<2)
>> CMD_LINE_ABOVE 4G = (1<<1)
>>                 .long   (RAMDISK_ABOVE_4G | CMD_LINE_ABOVE_4G |
>KERNEL_ABOVE_4G)
>
>more complete version:
>
>kernel_cap_bits:
>RAMDISK_ABOVE_4G  = (1<<0)
>KERNEL_ABOVE_4G =(1<<1)
>BOOT_PARAMS_ABOVE_4G=(1<<2)
>CMD_LINE_ABOVE 4G = (1<<3)
>                .long   (RAMDISK_ABOVE_4G | BOOT_PARAMS_ABOVE_4G |
>CMD_LINE_ABOVE_4G | KERNEL_ABOVE_4G)

-- 
Sent from my mobile phone. Please excuse brevity and lack of formatting.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/