Re: [PATCH 1/2] asm-generic: uaccess: allow arch to over-ride __get_user_fn()

From: Arnd Bergmann
Date: Tue Nov 20 2012 - 10:55:32 EST


On Tuesday 20 November 2012, Vineet.Gupta1@xxxxxxxxxxxx wrote:
> +#ifndef __get_user_fn
> static inline int __get_user_fn(size_t size, const void __user *ptr, void *x)
> {
> size = __copy_from_user(x, ptr, size);
> return size ? -EFAULT : size;
> }
>
> +#define __get_user_fn(sz, u, k) __get_user_fn(sz, u, k)
> +
> +#endif

This is ok as well. The idea with the asm-generic __copy_from_user()
implementation is to separate out the cases where you have just
a few bytes and handle them efficiently inline. If you don't want
to do that for some reason, overriding __get_user_fn works
as well. The resulting object code should be the same.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/