Re: [PATCH 1/3] perf session: Add perf_session__delete_env

[Arnaldo Carvalho de Melo]

Em Tue, Nov 20, 2012 at 05:31:15PM +0800, Feng Tang escreveu:
> +static void perf_session__delete_env(struct perf_session *self)
> +{
> +	struct perf_session_env *env = &self->header.env;
> +
> +	free(env->hostname);
> +	free(env->os_release);
> +	free(env->version);
> +	free(env->arch);
> +	free(env->cpu_desc);
> +	free(env->cpuid);
> +
> +	free(env->cmdline);
> +	free(env->sibling_cores);
> +	free(env->sibling_threads);
> +	free(env->numa_nodes);
> +	free(env->pmu_mappings);
> +}

The object being deleted is a perf_session_env, so please make it
perf_session_env__delete(struct perf_session_env *env), and avoid using
'self'.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/