Re: DVS regulator drivers

From: Guennadi Liakhovetski
Date: Tue Nov 20 2012 - 05:02:57 EST


Sorry, one more point, that I raised in the original mail yesterday and
that I forgot about, when replying today:

On Tue, 20 Nov 2012, Mark Brown wrote:

> On Mon, Nov 19, 2012 at 12:52:09PM +0100, Guennadi Liakhovetski wrote:

[snip]

> > /* Always set the ON status to the minimum voltage */
> >
> > but I actually don't see, where the minimum is selected. It seems instead
> > in this case the "ON" value is just set:

In other words, I don't see where voltages are compared to select the
minimum to be used for .on_vsel. Instead, it seems, .on_vsel is always set
to the new value, and, if it is also higher then the old .dvs_vsel value,
.dvs_vsel is _also_ set to the new voltage, in which case they become
equal. Is this the intended behaviour?

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/