Re: [PATCH RFT] regulator: da9055: Fix return wrong selector inda9055_regulator_get_voltage_sel

[Mark Brown]

On Tue, Nov 20, 2012 at 12:39:07PM +0800, Axel Lin wrote:
> We do "selector += info->volt.v_offset" in da9055_regulator_set_voltage_bits()
> to take care of voltage range that does not start with 0 offset.
> Thus in da9055_regulator_get_voltage_sel() we should do corresponding
> "sel -= volt.v_offset" before returning selector.
> Otherwise, we pass wrong selector for list_voltage callback.

No, we should just be using raw register values as the selectors and
fixing this in list_voltage() by returning 0 for invalid selectors.

Attachment: signature.asc
Description: Digital signature