Re: [PATCH] pkt_sched: QFQ Plus: fair-queueing service at DRR cost

[David Miller]

From: Paolo Valente <paolo.valente@xxxxxxxxxx>
Date: Mon, 12 Nov 2012 17:48:33 +0100

> [This patch received positive feedback from Stephen Hemminger ("put in
> net-next"), but no further feedback or decision. So I am (re)sending
> an updated version of it. The only differences with respect to the
> previous version are the support for TSO/GSO (taken from QFQ), and a
> hopefully improved description.]

Can you rearrange the logic so that the compiler doesn't emit this
warning?

In file included from net/sched/sch_qfq.c:18:0:
net/sched/sch_qfq.c: In function ʽqfq_dequeueʼ:
include/net/sch_generic.h:480:15: warning: ʽskbʼ may be used uninitialized in this function [-Wmaybe-uninitialized]
net/sched/sch_qfq.c:1007:18: note: ʽskbʼ was declared here

You and I both know that SKB will be initialized at this point, but
the compiler can't see it clearly enough.

Thanks.
θΊ{.nΗ+?·???­?+%?Λlzwm?ιb?맲ζμrΈ?zX§»?w??{ayΊΚ?Ϊ?λ,j­ʼf£ʼ·h??ΰzΉ?w?ʼΈʼ·¦j:+v?¨?wθjΨmΆ??Ύ«?κηzZ+?ω???έʼj"?ϊ!ΆiO?ζ¬z·?vΨ^Άm§?πΓnΖ?ΰώY&?