Re: [PATCH 46/58] x86: arch/x86/kernel/irqinit.c: Add prototype forinit_IRQ

[Josh Triplett]

On Mon, Nov 19, 2012 at 10:36:17AM +0000, David Howells wrote:
> Josh Triplett <josh@xxxxxxxxxxxxxxxx> wrote:
> > arch/x86/kernel/irqinit.c defines an __init function init_IRQ, called
> > from init/main.c.  No header file prototypes init_IRQ, because
> > init/main.c tends to directly define prototypes for init functions it
> > calls, rather than including appropriate headers.  So, add a prototype
> > of init_IRQ to arch/x86/kernel/irqinit.c right above the definition, to
> > satisfy gcc (-Wmissing-prototypes) and Sparse (-Wdecl).
> 
> Rather, you should put a declaration for it in a header file.

Happy to do so, except that as far as I can tell it doesn't seem
appropriate for any existing header, and creating a new header for the
sole purpose of that one prototype seems excessive, particularly since
the function only has the one call from init/main.c.  Nonetheless, if
you'd like a new header created for that prototype, or you have a
suggestion for an existing header I missed that seems appropriate, let
me know and I'll respin the patch.

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/