Re: [PATCH 4/7] power_supply: add throttle state

[Anton Vorontsov]

On Thu, Oct 18, 2012 at 10:14:03PM +0530, Jenny TC wrote:
> The charger and battery temperature contribute to the
> platform thermal. The only way to control the temperature
> is to control the charging. The charging can be controlled in different
> way. This could be disabling charger, disabling charging, adjusting CC,
> or by adjusting the INLMT. This patch adds a structure to define the
> charger throttle actions. Also this patch adds a throttle_states
> field to the struct power_supply which can be used by the charger
> driver to define it's throttle actions for different states
> 
> Signed-off-by: Jenny TC <jenny.tc@xxxxxxxxx>
> ---
>  include/linux/power_supply.h |   13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
> index eea1709..b4eb0af 100644
> --- a/include/linux/power_supply.h
> +++ b/include/linux/power_supply.h
> @@ -183,6 +183,18 @@ union power_supply_propval {
>  	const char *strval;
>  };
>  
> +enum psy_throttle_action {
> +

No need for this empty line.

> +	PSY_THROTTLE_DISABLE_CHARGER = 0,
> +	PSY_THROTTLE_DISABLE_CHARGING,
> +	PSY_THROTTLE_CC_LIMIT,
> +	PSY_THROTTLE_INPUT_LIMIT,
> +};
> +
> +struct power_supply_throttle {
> +	enum psy_throttle_action throttle_action;
> +	unsigned throttle_val;

Let's be consistent. unsigned int.

> +};

Empty line is needed here.

>  struct power_supply {
>  	const char *name;
>  	enum power_supply_type type;
> @@ -192,6 +204,7 @@ struct power_supply {
>  	char **supplied_to;
>  	unsigned long supported_cables;
>  	size_t num_supplicants;
> +	struct power_supply_throttle *throttle_states;
>  
>  	int (*get_property)(struct power_supply *psy,
>  			    enum power_supply_property psp,
> -- 
> 1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/