Re: [PATCH v2 3/3 UPDATED] i2c / ACPI: add ACPI enumeration support

From: Mika Westerberg
Date: Sun Nov 18 2012 - 10:52:33 EST


On Sat, Nov 17, 2012 at 12:24:45PM +0100, Rafael J. Wysocki wrote:
> Well, maybe there is one. Perhaps we can make acpi_platform_notify()
> call acpi_bind_one() upfront and only if that fails, do the whole
> type->find_device() dance? Of course, acpi_bind_one() would need to
> be modified slightly too, like in the patch below.
>
> If we did that, acpi_i2c_add_device() would only need to assign acpi_handle
> as appropriate before calling i2c_new_device() (and analogously for SPI).
>
> What do you think?

This is certainly better than the thing we use currently. It makes adding
I2C and SPI support much shorter and simpler. If others don't object I
would suggest that we switch to use this method.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/