Re: [PATCH] Lib:The patch include fix for "-" during string to long conversion

From: George Spelvin
Date: Sun Nov 18 2012 - 09:04:45 EST


Namit Gupta wrote:
> @@ -91,10 +98,18 @@ EXPORT_SYMBOL(simple_strtol);
> */
> long long simple_strtoll(const char *cp, char **endp, unsigned int base)
> {
>
> long l;
>
> if (cp[0] != '-')
> return simple_strtoull(cp, endp, base);
> l = -simple_strtoull(cp+1, endp, base);

In addition to the somewhat ugly the leading blank line,
I'd call this not very well tested.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/