Re: [RFC PATCH 04/06] input/rmi4: Config files and makefiles

[Linus Walleij]

On Sat, Nov 17, 2012 at 4:58 AM, Christopher Heiny <cheiny@xxxxxxxxxxxxx> wrote:

> Infrastructure files for configuration and building.
>
>
> Signed-off-by: Christopher Heiny <cheiny@xxxxxxxxxxxxx>
>

Cut blank line.

> Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxxxxxx>
> Cc: Naveen Kumar Gaddipati <naveen.gaddipati@xxxxxxxxxxxxxx>
> Cc: Joeri de Gram <j.de.gram@xxxxxxxxx>

(...)
> +++ b/drivers/input/rmi4/Makefile
> @@ -0,0 +1,22 @@
> +obj-$(CONFIG_RMI4_BUS) += rmi_bus.o
> +obj-$(CONFIG_RMI4_I2C) += rmi_i2c.o
> +obj-$(CONFIG_RMI4_GENERIC) += rmi_driver.o rmi_f01.o
> +obj-$(CONFIG_RMI4_F11) += rmi_f11.o
> +
> +ccflags-$(CONFIG_RMI4_DEBUG) += -DDEBUG
> +


>From here:

> +ifeq ($(KERNELRELEASE),)
> +
> +# KERNELDIR ?= /home/<AndroidKernelDirectory>
> +PWD := $(shell pwd)
> +
> +.PHONY: build clean
> +
> +build:
> +       $(MAKE) -C $(KERNELDIR) M=$(PWD) modules
> +
> +clean:
> +       rm -rf *.o *~ core .depend .*.cmd *.ko *.mod.c
> +
> +endif

This stuff looks weird. Like some local build rule to just rebuild
this part, and the commented-out Android thing is really just
cruft. Just delete all this, keep it in your private delta
if you need it.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/